feat: Use lockfiles when determining what packages changed across commits #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chris-olszewski is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
…kspace-filters-use-of
…kspace-filters-use-of
chris-olszewski
force-pushed
the
chrisolszewski/turbo-537-improve-changed-workspace-filters-use-of
branch
from
a00f42c to
664038a
Compare
…kspace-filters-use-of
NicholasLYang
approved these changes
Feb 1, 2023
| return resolvedPkgs, nil | ||
| } | ||
|
|
||
| func transitiveClosureHelper(wg *errgroup.Group, pkg *fs.PackageJSON, lockfile lockfile.Lockfile, unresolvedDirectDeps map[string]string, resolvedDeps mapset.Set) { | ||
| for directDepName, unresolvedVersion := range unresolvedDirectDeps { | ||
| directDepName := directDepName |
There was a problem hiding this comment.
What's the purpose of these lines?
There was a problem hiding this comment.
If we don't copy the values here then it'll resolve as the same value in every iteration of the loop: https://github.com/golang/go/wiki/CommonMistakes#using-reference-to-loop-iterator-variable
I'm so excited for Rust
| pkg.TransitiveDeps = append(pkg.TransitiveDeps, lockfilePkg.Key) | ||
| pkg.Mu.Unlock() | ||
| resolvedDepsSet.Add(fmt.Sprintf("%s@%s", lockfilePkg.Key, lockfilePkg.Version)) | ||
| resolvedDeps.Add(lockfilePkg) |
There was a problem hiding this comment.
How come we can get rid of the lock here? Is it because we're only mutating resolvedDeps now? Are there any race conditions due to the wg.Go?
There was a problem hiding this comment.
Yeah, we needed the lock because each goroutine that was spun up via the working group could try to append TransitiveDeps and go slices aren't thread safe. mapset.Set is threadsafe so we don't need to lock anything up
…kspace-filters-use-of
…kspace-filters-use-of
mehulkar
pushed a commit
that referenced
this pull request
Feb 3, 2023
…mits (#3250) This PR attempts to address #2162 This PR was written to be conservative by nature and it will mark packages as changed on almost any lockfile change that isn't just a version bump. Notable changes: - Extended SCM interface as we need to be able to reconstruct old lockfile - Refactored calculation of the transitive closure of the package graph so a full `Context` object isn't required - Merged `TransitiveDeps` and `ExternalDeps` as they contained almost identical information I haven't been able to fully test this, but from a quick spot check of pnpm it seems to behave as expected. Needed testing: - [x] Npm - [x] Yarn - [x] Yarn2+ - [x] Pnpm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address #2162
This PR was written to be conservative by nature and it will mark packages as changed on almost any lockfile change that isn't just a version bump.
Notable changes:
Contextobject isn't requiredTransitiveDepsandExternalDepsas they contained almost identical informationI haven't been able to fully test this, but from a quick spot check of pnpm it seems to behave as expected.
Needed testing: